Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android imports stamp file write mode #26614

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Jun 7, 2021

'w' (write) and 'a' (append) are mutually exclusive open modes in python
-- 'w' truncates and opens for write; 'a' opens at end of file for
write; both create if the file doesn't exist.

Python 2.7 didn't warn about this; Python 3 does.

No new tests since the build is the test.

Issue: flutter/flutter#83043

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

'w' (write) and 'a' (append) are mutually exclusive open modes in python
-- 'w' truncates and opens for write; 'a' opens at end of file for
write; both create if the file doesn't exist.

Python 2.7 didn't warn about this; Python 3 does.
@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 7, 2021
@fluttergithubbot fluttergithubbot merged commit 806430a into flutter:master Jun 7, 2021
@cbracken cbracken deleted the fix-write-mode branch June 7, 2021 20:14
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants