Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 support for macOS/iOS builds #26627

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Python 3 support for macOS/iOS builds #26627

merged 1 commit into from
Jun 8, 2021

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Jun 8, 2021

Rolls buildroot commit 3ae5da2 and
migrates a print statement to Python 3 syntax.

No additional tests since the build is the test.

Issue: flutter/flutter#83043

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Python 3 support for macOS/iOS builds
0c5cc44 
Rolls buildroot commit 3ae5da2 and
migrates a print statement to Python 3 syntax.
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 8, 2021
@fluttergithubbot fluttergithubbot merged commit 096f96c into flutter:master Jun 8, 2021
@cbracken cbracken deleted the ios-python3 branch June 8, 2021 17:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2021
@engine-flutter-autoroll
096f96c Python 3 support for macOS/iOS builds (flutter/engine#26627)
96f2c0b
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@cbracken
Python 3 support for macOS/iOS builds (flutter#26627)
9569348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@cbracken @zanderso @fluttergithubbot