Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvaskit] Fix bug where empty scene doesn't overwrite contentful scene #26820

Merged
merged 3 commits into from Jun 18, 2021
Merged

[canvaskit] Fix bug where empty scene doesn't overwrite contentful scene #26820

merged 3 commits into from Jun 18, 2021

Conversation

harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Jun 18, 2021 •
edited

If we had previously drawn a scene, and then tried to draw an empty scene, the old scene wasn't overwritten. This PR fixes that.

Fixes flutter/flutter#84624

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen
Clear the base canvas before rendering.
7ed5f1a 
This avoids a problem where an empty scene will not overwrite a
previously drawn scene.
@harryterkelsen
Don't write golden
ebd8f1a
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 18, 2021
@google-cla google-cla bot added the cla: yes label Jun 18, 2021
@harryterkelsen harryterkelsen mentioned this pull request Jun 18, 2021
Merged
@harryterkelsen harryterkelsen merged commit a310c85 into flutter:master Jun 18, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 20, 2021
@engine-flutter-autoroll
a310c85 [canvaskit] Fix bug where empty scene doesn't overwrite conte…
1aa0009 
…ntful scene (flutter/engine#26820)
wqyfavor pushed a commit to wqyfavor/engine that referenced this pull request Jun 21, 2021
[canvaskit] Fix bug where empty scene doesn't overwrite contentful sc…
efac66c 
…ene (flutter#26820)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@moffatman
[canvaskit] Fix bug where empty scene doesn't overwrite contentful sc…
d44a971 
…ene (flutter#26820)
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
[canvaskit] Fix bug where empty scene doesn't overwrite contentful sc…
f26115e 
…ene (flutter#26820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@harryterkelsen @mdebbar