Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Resize synchronization shouldn't wait for vsync if window is hidden #26857

Merged
merged 3 commits into from Jun 30, 2021
Merged

Windows: Resize synchronization shouldn't wait for vsync if window is hidden #26857

merged 3 commits into from Jun 30, 2021

Conversation

knopp
Copy link
Member

@knopp knopp commented Jun 21, 2021

flutter/flutter#84985

Depending on circumstances this change can shave off about 30-40 ms from the time it takes to show new window.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jun 21, 2021
@knopp knopp requested a review from clarkezone June 21, 2021 14:32
@chinmaygarde
Copy link
Member

Can you rebase this on ToT please? There was an infra failure that has since been addressed.

@clarkezone
Copy link
Contributor

I'll take a look over the weekend if it hasn't already been submitted

clarkezone
clarkezone approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@clarkezone clarkezone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knopp knopp force-pushed the windows_performance_improvements branch from b269889 to 71680b1 Compare June 30, 2021 09:53
@knopp knopp merged commit c31e8e3 into flutter:master Jun 30, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2021
@engine-flutter-autoroll
c31e8e3 Windows: Resize synchronization shouldn't wait for vsync if w…
86cb06e 
…indow is hidden (flutter/engine#26857)
@knopp knopp deleted the windows_performance_improvements branch July 17, 2021 09:24
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@knopp @moffatman
Windows: Resize synchronization shouldn't wait for vsync if window is…
69d7aff 
… hidden (flutter#26857)

* Resize synchronization shouldn't wait for vsync if window is hidden
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@knopp
Windows: Resize synchronization shouldn't wait for vsync if window is…
017c1f9 
… hidden (flutter#26857)

* Resize synchronization shouldn't wait for vsync if window is hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@clarkezone clarkezone clarkezone approved these changes

Assignees
No one assigned
Labels
cla: yes platform-windows
Projects
None yet
Milestone
No milestone
3 participants
@knopp @chinmaygarde @clarkezone