Use unstripped executables when running tests on Linux #26921
Conversation
testing/run_tests.py
Outdated
| # stack traces on Linux. | ||
| executable = os.path.join(build_dir, "exe.unstripped", executable_name) | ||
| # Some tests depend on the EGL/GLES libraries placed in the build directory. | ||
| env = {"LD_LIBRARY_PATH": build_dir} |
There was a problem hiding this comment.
I wonder if we should just modify the build output directory for unstripped executable to just be next to stripped variants. That way, we won't have to do library path manipulations or extra flags. Perhaps just have a suffix to the executable name (exe_name_unstripped). This will also help in the cases where folks need to attach debuggers and such to the unstripped exe runs.
I suppose the Right™ way to do this would be have stripping be a target specific option but right now its all or nothing unfortunately.
There was a problem hiding this comment.
I would prefer to keep the current directory structure in order to maintain similarity to the original Chromium build rules (and other build rules like Dart's that might assume Chromium's setup)
Most of the engine tests can run directly out of exe.unstripped (in particular, the auto-generated GetFixturesPath paths are fully qualified and do not depend on the location of the executable). But the embedder tests that rely on SwiftShader EGL/GLES must have a way to locate those libraries.
There was a problem hiding this comment.
Sure. It's your call. LGTM either way.
jason-simmons
force-pushed
the
absl_run_tests_unstripped
branch
3 times, most recently
from
48ed316
to
9417c39
Compare
jason-simmons
force-pushed
the
absl_run_tests_unstripped
branch
from
9417c39
to
e144b63
Compare
jason-simmons
added
the
waiting for tree to go green
See flutter/flutter#83286