Prepare for cfv2 unittests. #27036
Merged
Prepare for cfv2 unittests. #27036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandarrengoog
added
cla: yes
Work in progress (WIP)
chandarrengoog
changed the title
Use `fuchsia_test_archive` instead of `fuchsia_archive` and add plumbing for cml includes in build rules. Soft transition https://cs.opensource.google/flutter/recipes/+/master:recipes/femu_test.resources/run_vdl_test.sh to use `run-test-suite` instead of `run-test-component` for v2 components. Remove `//testing/fuchsia/run_tests.sh` as there are no longer any references to it. Migrating tests to cfv2 will be easier if we don't have to account for this script. See https://fxbug.dev/79691.
chaselatta
approved these changes
Jun 30, 2021
arbreng
approved these changes
Jun 30, 2021
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 1, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
pbo-linaro
pushed a commit
to pbo-linaro/flutter-recipes
that referenced
this pull request
Nov 24, 2022
This cl is dependent on flutter/engine#27036. See https://fxbug.dev/79691. Change-Id: Ia8a185ae2dcf4948964b03c4d9b95959ff635da8 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/15040 Reviewed-by: Keyong Han <keyonghan@google.com> Reviewed-by: Chase Latta <chaselatta@google.com> Reviewed-by: David Worsham <dworsham@google.com> Commit-Queue: Darren Chan <chandarren@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
fuchsia_test_archiveinstead offuchsia_archiveand add plumbing for cml includes in build rules.Soft transition https://cs.opensource.google/flutter/recipes/+/master:recipes/femu_test.resources/run_vdl_test.sh to use
run-test-suiteinstead ofrun-test-componentfor v2 components.Remove
//testing/fuchsia/run_tests.shas there are no longer any references to it.Migrating tests to cfv2 will be easier if we don't have to account for this script.
See https://fxbug.dev/79691.
CC: @naudzghebre