Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scrollable unfocusable when voiceover is running #27118

Merged
merged 1 commit into from Jul 1, 2021
Merged

Make scrollable unfocusable when voiceover is running #27118

merged 1 commit into from Jul 1, 2021

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jul 1, 2021

The feature is not needed in voiceover.

Fixes flutter/flutter#85725

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@chunhtai chunhtai requested a review from gaaclarke July 1, 2021 19:58
gaaclarke
gaaclarke approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chunhtai chunhtai merged commit 09343ca into flutter:master Jul 1, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 1, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 1, 2021
@engine-flutter-autoroll
09343ca Make scrollable unfocusable when voiceover is running (flutte…
8d869b9 
…r/engine#27118)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 2, 2021
@engine-flutter-autoroll
09343ca Make scrollable unfocusable when voiceover is running (flutte…
0d235ab 
…r/engine#27118)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@chunhtai @moffatman
Make scrollable unfocusable when voiceover is running (flutter#27118)
9af28f3
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@chunhtai
Make scrollable unfocusable when voiceover is running (flutter#27118)
0390eef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
cla: yes platform-ios
Projects
None yet
Milestone
No milestone
2 participants
@chunhtai @gaaclarke