add support for SkPathEffect to DisplayList #27155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
reviewed
Jul 3, 2021
flow/display_list.cc
Outdated
| @@ -1074,22 +1075,27 @@ void DisplayListBuilder::setBlendMode(SkBlendMode mode) { | |||
| void DisplayListBuilder::setFilterQuality(SkFilterQuality quality) { | |||
| Push<SetFilterQualityOp>(0, quality); | |||
| } | |||
| void DisplayListBuilder::setShader(sk_sp<SkShader> shader) { | |||
| void DisplayListBuilder::setShader(const sk_sp<SkShader> shader) { | |||
There was a problem hiding this comment.
I don't think this use of const does anything useful. If anything, it makes the std::move(shader) resort to a copy instead of a move. Did you perhaps mean sk_sp<const SkShader> shader?
chinmaygarde
approved these changes
Jul 3, 2021
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 4, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
This was referenced Aug 27, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem of not preserving the SkPathEffects in the paint used by the Text engine as seen in the golden test failures in the engine roll (flutter/flutter#85802)
This fix is related to the recent revert of enabling the DisplayList by default (#27153)
Includes tests for the new attribute and some minor edits to other attributes.
Note that SkPictureRecorder does not compute the bounds of these path effects properly in the drawPoints() methods without the workaround included in the SkCanvas rendering in the tests. The DisplayList bounds calculations are OK in this respect and worked fine without modifications.