Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test for dart entrypoint args on macOS #27465

Merged
merged 1 commit into from Jul 16, 2021
Merged

Add a unit test for dart entrypoint args on macOS #27465

merged 1 commit into from Jul 16, 2021

Conversation

gw280
Copy link
Contributor

@gw280 gw280 commented Jul 16, 2021

Backfill tests for #21789

flutter/flutter#32986

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@gw280 gw280 requested a review from chunhtai July 16, 2021 01:28
@google-cla google-cla bot added the cla: yes label Jul 16, 2021
chunhtai
chunhtai approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gw280 gw280 merged commit 33641cc into flutter:master Jul 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@engine-flutter-autoroll
33641cc Add a unit test for dart entrypoint args on macOS (flutter/en…
7583827 
…gine#27465)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@engine-flutter-autoroll
33641cc Add a unit test for dart entrypoint args on macOS (flutter/en…
849ea59 
…gine#27465)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@engine-flutter-autoroll
33641cc Add a unit test for dart entrypoint args on macOS (flutter/en…
06a1d52 
…gine#27465)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@engine-flutter-autoroll
33641cc Add a unit test for dart entrypoint args on macOS (flutter/en…
47aff72 
…gine#27465)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 16, 2021
@engine-flutter-autoroll
33641cc Add a unit test for dart entrypoint args on macOS (flutter/en…
5adecd0 
…gine#27465)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
@moffatman
Add a unit test for dart entrypoint args on macOS (flutter#27465)
363509e
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Add a unit test for dart entrypoint args on macOS (flutter#27465)
3a03734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
cla: yes platform-macos
Projects
None yet
Milestone
No milestone
3 participants
@gw280 @chinmaygarde @chunhtai