Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not resolve external textures unless there is new frame available #27508

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Do not resolve external textures unless there is new frame available #27508

merged 4 commits into from
Jul 19, 2021

Conversation

knopp
Copy link
Member

@knopp knopp commented Jul 17, 2021

Fixes flutter/flutter#86601

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Jul 17, 2021
@flutter-dashboard

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added the cla: yes label Jul 17, 2021
@knopp knopp removed the needs tests label Jul 17, 2021
@knopp knopp requested a review from iskakaushik July 17, 2021 12:29
@knopp knopp changed the title Do not resolve external textures unless there is new frame Do not resolve external textures unless there is new frame available Jul 17, 2021
@knopp knopp changed the title Do not resolve external textures unless there is new frame available WIP: Do not resolve external textures unless there is new frame available Jul 17, 2021
@knopp knopp changed the title WIP: Do not resolve external textures unless there is new frame available Do not resolve external textures unless there is new frame available Jul 17, 2021
iskakaushik
iskakaushik approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 19, 2021
@fluttergithubbot fluttergithubbot merged commit 9edde74 into flutter:master Jul 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2021
@engine-flutter-autoroll
9edde74 Do not resolve external textures unless there is new frame av…
56448b1 
…ailable (flutter/engine#27508)
@jnschulze jnschulze mentioned this pull request Aug 10, 2021
Closed
@cbenhagen cbenhagen mentioned this pull request Aug 31, 2021
Closed
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@knopp
Do not resolve external textures unless there is new frame available (f…
7f610e4 
…lutter#27508)
@xiaowei-guan xiaowei-guan mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

Assignees
No one assigned
Labels
cla: yes embedder Related to the embedder API waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@knopp @iskakaushik @fluttergithubbot