Eliminate Android-specific Vulkan support #28239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
force-pushed
the
no-enable-vulkan
branch
2 times, most recently
from
bdca66e
to
3be8a83
Compare
This eliminates Vulkan support for Android. As of flutter#27980 (c2f2291) we are no longer running Android-Vulkan builds. This eliminates the --enable-vulkan flag from tools/gn and any code that is only reachable when that flag is enabled. Note that after this patch, `shell_enable_vulkan` is always false, however the //flutter/shell/gpu:gpu_surface_vulkan target and source files remain since they are still used when `test_enable_vulkan` is true, which is the case when `is_fuchsia` is true. Note that these files are *not* built as part of a regular fuchsia build (see the `shell_gpu_configuration` in //shell/platform/fuchsia/flutter/BUILD.gn), but may be enabled once the Fuchsia embedder is migrated to the Embedder API. Also updates TODOs to dworsham, who is the committer who'll be transitioning the Fuchsia embedder to the embedding API.
cbracken
force-pushed
the
no-enable-vulkan
branch
from
3be8a83
to
a3745fa
Compare
zanderso
approved these changes
Aug 21, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2021
pbo-linaro
pushed a commit
to pbo-linaro/flutter-recipes
that referenced
this pull request
Nov 24, 2022
This has never shipped and isn't properly supported, so eliminating the build and, in a separate patch [1], the associated code. [1] flutter/engine#28239 Change-Id: Ie17bee40d88a35c8af1602d83be01c021c0266fd Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/17284 Commit-Queue: Chris Bracken <cbracken@google.com> Reviewed-by: Zach Anderson <zra@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates Vulkan support for Android. As of #27980
(c2f2291) we are no longer running Android-Vulkan builds. This
eliminates the --enable-vulkan flag from tools/gn and any code that is
only reachable when that flag is enabled.
Note that after this patch,
shell_enable_vulkanis always false,however the //flutter/shell/gpu:gpu_surface_vulkan target and source
files remain since they are still used when
test_enable_vulkanistrue, which is the case when
is_fuchsiais true. Note that these filesare not built as part of a regular fuchsia build (see the
shell_gpu_configurationin //shell/platform/fuchsia/flutter/BUILD.gn),but may be enabled once the Fuchsia embedder is migrated to the Embedder
API.
Related recipe patch: https://flutter-review.googlesource.com/c/recipes/+/17284
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.