New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use rFD in pre-Q versions #28593
Conversation
shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
Outdated
Show resolved
Hide resolved
// permissions in some Android versions. | ||
// * rFD behavior isn't tested on pre-Q versions. | ||
// See https://github.com/flutter/flutter/issues/46172, and | ||
// https://github.com/flutter/flutter/issues/88767. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: consider adding that there are vendor-specific bugs.
How confident are we that this API works on all vendors after Q?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only know that a CTS test was added. Vendors should be running these tests, but we don't really know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit.
I am wondering if we know for sure that the Android team's coverage of reportFullyDrawn is good enough to trust it on all vendors after Q.
Android uses CTS for this. |
* 'Update Dart SDK to 3300f32' * Don't use rFD in pre-Q versions (#28593) * updated 3rd party license golden * hard-code Build.VERSION_CODE.S * renew cirrus key (#28584) Co-authored-by: Emmanuel Garcia <egarciad@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
Fixes flutter/flutter#88767
We cannot safely rely on this API since there's no test in Android prior to Q.