Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated unused element suppressions #28775

Merged
merged 2 commits into from Sep 23, 2021

Conversation

bdero
Copy link
Member

@bdero bdero commented Sep 21, 2021

Re: flutter/flutter#35164 - these seem to be recognized as used now.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bdero bdero changed the title WIP: Remove outdated unused element suppressions Remove outdated unused element suppressions Sep 22, 2021
@bdero bdero requested a review from dnfield September 23, 2021 17:45
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, looks like someone fixed the bug around this :)

LGTM, I will close the upstream bug.

@bdero bdero added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 23, 2021
@chinmaygarde chinmaygarde merged commit 7d023e8 into flutter:master Sep 23, 2021
@dnfield
Copy link
Contributor

dnfield commented Sep 23, 2021

(this was picked as a safe PR to merge from PR triage to kick the tree, which is red on something not related to the code at head)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants