Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Wiring required for partial update #28798

Closed
wants to merge 9 commits into from
Closed

WIP: Wiring required for partial update #28798

wants to merge 9 commits into from

Conversation

knopp
Copy link
Member

@knopp knopp commented Sep 22, 2021

Related Issues

flutter/flutter#33939

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@knopp
Unconditionally enable DiffContext
28741c3
@knopp
Do not evict culled-out layers from raster cache
07cdb10 
This should preserve current behavior - the lifespan of raster cache entries should be identical with and without partial repaint.
@knopp knopp changed the title WIP: Wiring required for partial update #25158 WIP: Wiring required for partial update Sep 22, 2021
@google-cla google-cla bot added the cla: yes label Sep 22, 2021
@knopp knopp mentioned this pull request Sep 22, 2021
Closed
9 tasks
@zanderso
Copy link
Member

zanderso commented Oct 7, 2021

@iskakaushik @knopp Checking in from PR triage to ask if this is blocked.

@knopp
Copy link
Member Author

knopp commented Oct 7, 2021

I'm closing this one. Relevant PR regarding partial updates right now is #28801, blocked on #29001.

@knopp knopp closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes embedder Related to the embedder API platform-android platform-fuchsia platform-ios
Projects
None yet
Milestone
No milestone
2 participants
@knopp @zanderso