Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable main branch. #28898

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Enable main branch. #28898

merged 1 commit into from
Sep 28, 2021

Conversation

godofredoc
Copy link
Contributor

This is in preparation to move testing to main branch.

Bug: flutter/flutter#90476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Enable main branch.
2117e8a 
This is in preparation to move testing to main branch.
@google-cla google-cla bot added the cla: yes label Sep 28, 2021
CaseyHillers
CaseyHillers approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 28, 2021
@fluttergithubbot fluttergithubbot merged commit bccb3a5 into flutter:master Sep 28, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 28, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 28, 2021
@engine-flutter-autoroll
bccb3a5 Enable main branch. (flutter/engine#28898)
8b9f706
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 28, 2021
@engine-flutter-autoroll
bccb3a5 Enable main branch. (flutter/engine#28898) (#90891)
99b210f
dnfield pushed a commit to dnfield/engine that referenced this pull request Oct 6, 2021
@godofredoc @dnfield
Enable main branch. (flutter#28898)
7732b84
@godofredoc godofredoc deleted the enable_main branch October 18, 2021 17:35
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@engine-flutter-autoroll @clocksmith
bccb3a5 Enable main branch. (flutter/engine#28898) (flutter#90891)
9bf039d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@godofredoc @CaseyHillers @fluttergithubbot