Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contrast enforcement for null values #29055

Merged
merged 5 commits into from Oct 7, 2021
Merged

Update contrast enforcement for null values #29055

merged 5 commits into from Oct 7, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Oct 6, 2021

Internal b/201754408

This updates the contrast enforcement of of the status and navigation bars on Android. It was not toggle-able as when we first added support for this we assumed the default value of true at all times unless undersired.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Oct 6, 2021
@Piinks Piinks mentioned this pull request Oct 6, 2021
Merged
8 tasks
@Piinks Piinks requested a review from goderbauer October 6, 2021 22:45
@Piinks
Copy link
Contributor Author

Piinks commented Oct 6, 2021

Related framework change: flutter/flutter#91396

goderbauer
goderbauer approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 7, 2021
@fluttergithubbot fluttergithubbot merged commit 221ca5e into flutter:master Oct 7, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 7, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 7, 2021
@engine-flutter-autoroll
221ca5e Update contrast enforcement for null values (flutter/engine#2…
2c7ad63 
…9055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@wytesk133 wytesk133 wytesk133 approved these changes

Assignees
No one assigned
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@Piinks @goderbauer @wytesk133 @fluttergithubbot