Revert "Enable Skia's Vulkan backend on all non-mobile platforms, and… #29794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test SwiftShader Vulkan on all GL unittests platforms (flutter#29520)" Causes the following build breakage (Win32): [19/1564] CXX obj/flutter/vulkan/vulkan.vulkan_window.obj FAILED: obj/flutter/vulkan/vulkan.vulkan_window.obj ninja -t msvc -e environment.x64 -- ../../buildtools/windows-x64/clang/bin/clang-cl.exe /nologo /showIncludes @obj/flutter/vulkan/vulkan.vulkan_window.obj.rsp /c ../../flutter/vulkan/vulkan_window.cc /Foobj/flutter/vulkan/vulkan.vulkan_window.obj /Fdobj/flutter/vulkan/vulkan_cc.pdb ../../flutter/vulkan/vulkan_window.cc(125,24): error: no member named 'MakeVulkan' in 'GrDirectContext' GrDirectContext::MakeVulkan(backend_context, options); ~~~~~~~~~~~~~~~~~^ 1 error generated. This reverts commit bba38c0.
flutter-dashboard
bot
added
embedder
|
A clean build fixed this for me. |
|
I think this might have been due to missing |
|
Yep, that was exactly the reason. I should have left a note for anyone else who hits this bug by searching for the error message. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… test SwiftShader Vulkan on all GL unittests platforms (#29520)"
Causes the following build breakage (Win32):
This reverts commit bba38c0.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.