Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Use fuzzy matching in Gold #29847

Merged
merged 10 commits into from Nov 29, 2021
Merged

[web] Use fuzzy matching in Gold #29847

merged 10 commits into from Nov 29, 2021

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Nov 19, 2021

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Nov 19, 2021
@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@mdebbar mdebbar marked this pull request as ready for review November 24, 2021 18:09
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar mdebbar requested a review from yjbanov November 29, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes needs tests platform-web Code specifically for the web engine
Projects
None yet
2 participants