New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify clip alignment for partial repaint #31359
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
e2e2be5
to
58fbf1a
Compare
cc @iskakaushik Do you have the cycles to review this please? |
The original Android PR was reverted because of internal performance regressions. |
@knopp The revert did not land so this ought to be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
37d5ff1
to
581fd54
Compare
Gold has detected about 10 new digest(s) on patchset 3. |
Following up on why the presubs have not been kicked off on this patch. |
From PR review triage: What is the status of this PR? |
581fd54
to
90698f9
Compare
This can be merged as soon as the tests pass. |
Fixes: flutter/flutter#97482
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.