Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VsyncWaiter schedules unneeded extra AwaitVSync callbacks for one frame #36406

Merged
merged 6 commits into from Oct 14, 2022

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Sep 26, 2022

Consider the following sequence:

  • ScheduleSecondaryCallback(id1, callback1)
  • ScheduleSecondaryCallback(id2, callback2)

Then, without this fix, the AwaitVSync will be called twice. Then, FireCallback will be called twice at the beginning of the next frame. But we know that FireCallback calls all primary and secondary callbacks, so being called twice just waste some computation resource.

By the way, the following sequences are all ok without bugs:

  • AsyncWaitForVsync
  • ScheduleSecondaryCallback(id1)
  • ScheduleSecondaryCallback(id2)

or

  • ScheduleSecondaryCallback(id1)
  • AsyncWaitForVsync
  • ScheduleSecondaryCallback(id2)

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#112439

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fzyzcjy fzyzcjy changed the title Fix VsyncWaiter schedules multiple AwaitVSync for one frame VsyncWaiter schedules unneeded extra AwaitVSync callbacks for one frame Sep 26, 2022
@dnfield dnfield added autosubmit Merge PR when tree becomes green via auto submit App and removed needs tests labels Oct 14, 2022
@auto-submit auto-submit bot merged commit 1725031 into flutter:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
3 participants