Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia][scenic] Fix logical size in flatland platform view. #37053

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

shivesh-ganju
Copy link
Contributor

@shivesh-ganju shivesh-ganju commented Oct 26, 2022

This PR fixes a bug identified after DPR feature was added in flatland where currently we do not multiple the logical size of the view by the pixel ratio.

This change is getting tested in input tests like mouse-input-test, touch-input-test

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This PR fixes a bug identified after DPR feature was added in flatland
where currently we do not multiple the logical size of the view by the
pixel ratio.

This change is getting tested in input tests like mouse-input-test,
touch-input-test
@akbiggs akbiggs added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Oct 26, 2022
@chinmaygarde
Copy link
Member

@akbiggs Did you mean to remove the autosubmit tag? Looks like this PR is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants