-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Changes to EditableState to be able to handle Framework text selection shortcuts #37097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests!
Let's also add one to make sure EditingState.fromFrameworkMessage()
sets the composing values to -1
.
Could you also open the framework-side PR so reviewers can look at both PRs together?
@mdebbar Added that suggested tests and the PR in the description |
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
60c499e
to
6d3c372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rk text selection shortcuts (flutter/engine#37097)
…lection shortcuts (flutter#37097)
Currently there's an issue in which keyboard shortcuts (shift + arrow keys) don't autoscroll on web inputs and textfields. Delegating these keyboard actions to the framework fixes this issue and allows for a more consistent UX for web.
As part of that change, the
EditableState
class needs to be able to handle flipped base and extent offsets, as well as have sensible defaults for composing offsets.Part 1 fixes flutter/flutter#107707
Framework changes PR: flutter/flutter#114264
Pre-launch Checklist
///
).