Roll Dart SDK from 27c45cd51796 to 999f764b4fa3 (1 revision) #37838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dart.googlesource.com/sdk.git/+log/27c45cd51796..999f764b4fa3 2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-417.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
added
the
autosubmit
skia-flutter-autoroll
force-pushed
the
dart-sdk-flutter-engine-f3eaeb97-e3d6-4721-819a-2fffc2eb25f6-1669110677
branch
from
981f089
to
418f976
Compare
fluttergithubbot
approved these changes
Nov 22, 2022
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37838, due to - The status or check suite Mac Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
skia-flutter-autoroll
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 37838, due to - The status or check suite Windows Web Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
Commit queue failed; closing this roll. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 22, 2022
This reverts commit aab6ab8. Reason for revert: Broke Flutter roll flutter/engine#37838 Original change's description: > [pkg:js] Disallow using @staticInterop synthetic constructors > > Change-Id: I5c74369ee8ae97fcc21032464fcb8fea987022d9 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268107 > Reviewed-by: Joshua Litt <joshualitt@google.com> > Reviewed-by: Riley Porter <rileyporter@google.com> > Reviewed-by: Sigmund Cherem <sigmund@google.com> TBR=sigmund@google.com,joshualitt@google.com,rileyporter@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com,srujzs@google.com Change-Id: I6caf4b776191e8eed9877c43f900ae6300f1f5c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271440 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 28, 2022
This reverts commit aa252e9. Reason for revert: Flutter engine is migrated to not use synthetic constructors. Original change's description: > Revert "[pkg:js] Disallow using @staticInterop synthetic constructors" > > This reverts commit aab6ab8. > > Reason for revert: Broke Flutter roll flutter/engine#37838 > > Original change's description: > > [pkg:js] Disallow using @staticInterop synthetic constructors > > > > Change-Id: I5c74369ee8ae97fcc21032464fcb8fea987022d9 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/268107 > > Reviewed-by: Joshua Litt <joshualitt@google.com> > > Reviewed-by: Riley Porter <rileyporter@google.com> > > Reviewed-by: Sigmund Cherem <sigmund@google.com> > > TBR=sigmund@google.com,joshualitt@google.com,rileyporter@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com,srujzs@google.com > > Change-Id: I6caf4b776191e8eed9877c43f900ae6300f1f5c2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271440 > Reviewed-by: Sigmund Cherem <sigmund@google.com> > Commit-Queue: Srujan Gaddam <srujzs@google.com> > Reviewed-by: Srujan Gaddam <srujzs@google.com> # Not skipping CQ checks because this is a reland. Change-Id: Iaa538bb5f309a46c320bf1781c3d1a7148ec7be7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271500 Reviewed-by: Sigmund Cherem <sigmund@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Reviewed-by: Riley Porter <rileyporter@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> Reviewed-by: Joshua Litt <joshualitt@google.com>
skia-flutter-autoroll
deleted the
dart-sdk-flutter-engine-f3eaeb97-e3d6-4721-819a-2fffc2eb25f6-1669110677
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart.googlesource.com/sdk.git/+log/27c45cd51796..999f764b4fa3
2022-11-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 2.19.0-417.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md