Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision)" #37982

Conversation

zanderso
Copy link
Member

Reverts #37973

This looks like a mistaken roll-back of Dart to a known bad commit, which is causing the engine to fail to roll into the framework.

@zanderso
Copy link
Member Author

I'm going to TBR this, since getting caught up again could take many hours.

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App revert Label used to revert changes in a closed and merged pull request. labels Nov 30, 2022
@zanderso zanderso merged commit 1bda5f8 into main Nov 30, 2022
@zanderso zanderso deleted the revert-37973-dart-sdk-flutter-engine-f025f132-8dbe-4db8-aefa-d8db18527ec7-1669778813 branch November 30, 2022 16:04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 30, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 30, 2022
…116290)

* 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973)

* 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974)

* 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977)

* 13f136efb [deps] Add `package:intl` (flutter/engine#37980)

* 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (#37973)" (flutter/engine#37982)
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
…lutter#116290)

* 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973)

* 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974)

* 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977)

* 13f136efb [deps] Add `package:intl` (flutter/engine#37980)

* 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#116290)

* 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973)

* 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974)

* 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977)

* 13f136efb [deps] Add `package:intl` (flutter/engine#37980)

* 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#116290)

* 94bed734c Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter/engine#37973)

* 047b6754b Roll Fuchsia Mac SDK from gF3YVyOjqNbzT-L9Y... to ECusE22sNK6IbnL6L... (flutter/engine#37974)

* 787044d2c [Impeller Scene] Command encoding (flutter/engine#37977)

* 13f136efb [deps] Add `package:intl` (flutter/engine#37980)

* 1bda5f8c0 Revert "Roll Dart SDK from 88473a3b63ff to a55712b2de3f (0 revision) (flutter#37973)" (flutter/engine#37982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App revert Label used to revert changes in a closed and merged pull request. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
3 participants