Update glfw to head and imgui to the docking branch #38085
Conversation
|
Gold has detected about 35 new digest(s) on patchset 3. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
It looks to me like there are a bunch of new variations of the same license caused by the years being updated in some files and not in others over time. Additionally, sometimes the licenses have a Google LLC line and sometimes they don't. |
|
Gold has detected about 72 new digest(s) on patchset 4. |
bdero
force-pushed
the
bdero/update-glfw-imgui
branch
from
0379d60
to
4624605
Compare
…116571) * a1bfb413b Roll Dart SDK from 52599799b666 to 35a9facce191 (4 revisions) (flutter/engine#38091) * a588dbe8b Update glfw to head and imgui to the docking branch (flutter/engine#38085)
…lutter#116571) * a1bfb413b Roll Dart SDK from 52599799b666 to 35a9facce191 (4 revisions) (flutter/engine#38091) * a588dbe8b Update glfw to head and imgui to the docking branch (flutter/engine#38085)
…lutter#116571) * a1bfb413b Roll Dart SDK from 52599799b666 to 35a9facce191 (4 revisions) (flutter/engine#38091) * a588dbe8b Update glfw to head and imgui to the docking branch (flutter/engine#38085)
…lutter#116571) * a1bfb413b Roll Dart SDK from 52599799b666 to 35a9facce191 (4 revisions) (flutter/engine#38091) * a588dbe8b Update glfw to head and imgui to the docking branch (flutter/engine#38085)
The GLFW backend in the ImGui docking branch relies on
glfwGetMonitorWorkarea, which was introduced later than the hash we're running. I tried to perform this GLFW upgrade earlier when I first added ImGui as a test dependency, but ran into some trouble. Things seem to be going more smoothly this time, but we'll see if I can get it passing on all targets. 🤷♂️