Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DisplayList's dependency on SkAutoTMalloc #38359

Merged
merged 1 commit into from Dec 16, 2022

Conversation

jason-simmons
Copy link
Member

SkAutoTMalloc is not a public Skia API

SkAutoTMalloc is not a public Skia API
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar
Copy link
Contributor

flar commented Dec 16, 2022

This is a code switch from one mechanism to another equivalent mechanism so there is no way to test the change itself. Its correctness will be tested by existing unit and framework tests...

@flar flar removed the needs tests label Dec 16, 2022
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2022
@auto-submit auto-submit bot merged commit 60cf34e into flutter:main Dec 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 17, 2022
…117246)

* 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356)

* 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354)

* 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328)

* 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#117246)

* 1fe1ec414 Clarify semantics action dispatch id parameter (flutter/engine#38356)

* 985f4ac51 Ensure licenses excluded file list has newline at EOF (flutter/engine#38354)

* 4097c333f Update documentation to use `--local-web-sdk` flags. (flutter/engine#38328)

* 60cf34e2a Remove DisplayList's dependency on SkAutoTMalloc (flutter/engine#38359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants