Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Delete web_ui/BUILD.gn #38446

Merged
merged 2 commits into from
Dec 28, 2022
Merged

[web] Delete web_ui/BUILD.gn #38446

merged 2 commits into from
Dec 28, 2022

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 21, 2022

Is this being used anywhere?

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 21, 2022
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is unused. LGTM, thanks for catching this!

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #38446 at sha e78e941

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 28, 2022
@auto-submit auto-submit bot merged commit 0cfadcb into main Dec 28, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 28, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 28, 2022
…117751)

* 0cfadcb2f [web] Delete web_ui/BUILD.gn (flutter/engine#38446)

* 3655bf981 Roll Skia from e4c86c2fed9a to 2923399853d9 (2 revisions) (flutter/engine#38537)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
…lutter#117751)

* 0cfadcb2f [web] Delete web_ui/BUILD.gn (flutter/engine#38446)

* 3655bf981 Roll Skia from e4c86c2fed9a to 2923399853d9 (2 revisions) (flutter/engine#38537)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#117751)

* 0cfadcb2f [web] Delete web_ui/BUILD.gn (flutter/engine#38446)

* 3655bf981 Roll Skia from e4c86c2fed9a to 2923399853d9 (2 revisions) (flutter/engine#38537)
@mdebbar mdebbar deleted the mdebbar-patch-1 branch March 16, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens
Projects
None yet
2 participants