Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[web] Render in custom target (#37738)" #38469

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Revert "[web] Render in custom target (#37738)" #38469

merged 1 commit into from
Dec 22, 2022

Conversation

ditman
Copy link
Member

@ditman ditman commented Dec 22, 2022

This reverts commit 2358215.

Reverting to fix engine -> flutter roll: flutter/flutter#117510

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Dec 22, 2022
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2022
@auto-submit auto-submit bot merged commit 3b115f0 into flutter:main Dec 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 22, 2022
@engine-flutter-autoroll
3b115f033 Revert "[web] Render in custom target (flutter#37738)" (flu…
389f466 
…tter/engine#38469)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (#…
daa2ecf 
…117563)

* 23582159a [web] Render in custom target (flutter/engine#37738)

* 766f8fd91 Roll Fuchsia Mac SDK from UsYNZnnfR_s0OGQoX... to Xu_G6EQQ2UG48e5qI... (flutter/engine#38457)

* 6f829b7e3 Roll Dart SDK from fc0a3217b39a to cb6245d8f8d3 (1 revision) (flutter/engine#38458)

* 74d9ba455 Roll Skia from f1610a251e3a to 67904a365fdc (1 revision) (flutter/engine#38459)

* 19de6262b Roll Skia from 67904a365fdc to c93fa176c9ca (6 revisions) (flutter/engine#38460)

* 147ac7d02 Display list R-Tree culling (flutter/engine#38429)

* 3549fb1ed Roll Skia from c93fa176c9ca to 33807a735c32 (3 revisions) (flutter/engine#38464)

* d76ccb8f4 Roll Dart SDK from cb6245d8f8d3 to 47b0d07e6be9 (3 revisions) (flutter/engine#38465)

* 2c9e1d98d Roll Skia from 33807a735c32 to 89742d768c97 (3 revisions) (flutter/engine#38467)

* 3b115f033 Revert "[web] Render in custom target (#37738)" (flutter/engine#38469)

* ca0c843bf Roll Fuchsia Mac SDK from Xu_G6EQQ2UG48e5qI... to W0GUdjHi4gI48optN... (flutter/engine#38468)
@ditman ditman mentioned this pull request Dec 23, 2022
Merged
8 tasks
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@ditman @loic-sharma
Revert "[web] Render in custom target (flutter#37738)" (flutter#38469)
43e9138 
This reverts commit 2358215.
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@engine-flutter-autoroll @loic-sharma
Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (f…
54cbcc9 
…lutter#117563)

* 23582159a [web] Render in custom target (flutter/engine#37738)

* 766f8fd91 Roll Fuchsia Mac SDK from UsYNZnnfR_s0OGQoX... to Xu_G6EQQ2UG48e5qI... (flutter/engine#38457)

* 6f829b7e3 Roll Dart SDK from fc0a3217b39a to cb6245d8f8d3 (1 revision) (flutter/engine#38458)

* 74d9ba455 Roll Skia from f1610a251e3a to 67904a365fdc (1 revision) (flutter/engine#38459)

* 19de6262b Roll Skia from 67904a365fdc to c93fa176c9ca (6 revisions) (flutter/engine#38460)

* 147ac7d02 Display list R-Tree culling (flutter/engine#38429)

* 3549fb1ed Roll Skia from c93fa176c9ca to 33807a735c32 (3 revisions) (flutter/engine#38464)

* d76ccb8f4 Roll Dart SDK from cb6245d8f8d3 to 47b0d07e6be9 (3 revisions) (flutter/engine#38465)

* 2c9e1d98d Roll Skia from 33807a735c32 to 89742d768c97 (3 revisions) (flutter/engine#38467)

* 3b115f033 Revert "[web] Render in custom target (flutter#37738)" (flutter/engine#38469)

* ca0c843bf Roll Fuchsia Mac SDK from Xu_G6EQQ2UG48e5qI... to W0GUdjHi4gI48optN... (flutter/engine#38468)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (f…
a8254b7 
…lutter#117563)

* 23582159a [web] Render in custom target (flutter/engine#37738)

* 766f8fd91 Roll Fuchsia Mac SDK from UsYNZnnfR_s0OGQoX... to Xu_G6EQQ2UG48e5qI... (flutter/engine#38457)

* 6f829b7e3 Roll Dart SDK from fc0a3217b39a to cb6245d8f8d3 (1 revision) (flutter/engine#38458)

* 74d9ba455 Roll Skia from f1610a251e3a to 67904a365fdc (1 revision) (flutter/engine#38459)

* 19de6262b Roll Skia from 67904a365fdc to c93fa176c9ca (6 revisions) (flutter/engine#38460)

* 147ac7d02 Display list R-Tree culling (flutter/engine#38429)

* 3549fb1ed Roll Skia from c93fa176c9ca to 33807a735c32 (3 revisions) (flutter/engine#38464)

* d76ccb8f4 Roll Dart SDK from cb6245d8f8d3 to 47b0d07e6be9 (3 revisions) (flutter/engine#38465)

* 2c9e1d98d Roll Skia from 33807a735c32 to 89742d768c97 (3 revisions) (flutter/engine#38467)

* 3b115f033 Revert "[web] Render in custom target (flutter#37738)" (flutter/engine#38469)

* ca0c843bf Roll Fuchsia Mac SDK from Xu_G6EQQ2UG48e5qI... to W0GUdjHi4gI48optN... (flutter/engine#38468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@ditman @eyebrowsoffire