Extract WideToUTF16String/UTF16StringToWide to FML #39006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
WideToUTF16
branch
4 times, most recently
from
5ec7530
to
d91e80a
Compare
In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811
yaakovschectman
approved these changes
Jan 19, 2023
|
The windows failures do look related. |
|
Yep - two of the tests were wrong; serves me right for adding Windows-specific tests from a Mac. |
|
Looking good now :) |
cbracken
added
the
autosubmit
|
Reverting as it broke the tree https://ci.chromium.org/p/flutter/builders/prod/Windows%20Host%20Engine/19925 |
godofredoc
added
revert
godofredoc
added a commit
that referenced
this pull request
Jan 20, 2023
This reverts commit 7bbe79e.
|
Oh wow. I'm curious how that wasn't caught in presubmit! Thanks for reverting. We should definitely not be using //third_party/accessibility:base outside of the accessibility tree. I'll fix that code and see if I can add a visibility restriction so people don't re-add code like that in future. |
|
Ah I see why it wasn't caught - a new usage was introduced in a separate PR between the time presubmits ran and the patch landed. |
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2023
…118869) * 7bbe79e10 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39006) * acca56ce0 Revert "Extract WideToUTF16String/UTF16StringToWide to FML (#39006)" (flutter/engine#39019) * 730e88fb6 [Impeller] Check the correct stencil coverage when deciding whether to elide a restore (flutter/engine#39023)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
* Extract WideToUTF16String/UTF16StringToWide to FML In third_party/accessibility, for string conversion, we use a mix of: * FML * third_party/accessibility base string utility functions * static functions local to the translation unit itself This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where: * the size of wchar_t and char16_t are the same * the encoding of wchar_t and char16_t are both UTF-16 which is the case for Windows, hence why these functions are implemented in a Windows-specific translation unit (wstring_conversion). Issue: flutter/flutter#118811 * Migrate UTF16ToWide as well
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
…9006)" (flutter#39019) This reverts commit 7bbe79e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In third_party/accessibility, for string conversion, we use a mix of:
This moves all conversions between UTF16 and wide strings to FML. Note that this implementation is only safe on platforms where:
Issue: flutter/flutter#118811
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.