Improve crashes if messenger APIs are used incorrectly #39041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
yaakovschectman,
stuartmorgan,
cbracken,
gaaclarke and
jnschulze
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cbracken
approved these changes
Jan 24, 2023
|
test-exempt: no semantic change (improves error messages and documentation) |
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 25, 2023
…119093) * 4165d4b9b Improve crashes if messenger APIs are used incorrectly (flutter/engine#39041) * bec40654a Roll Fuchsia Linux SDK from dWbkAZchFHtZE9Wt_... to E9m-Gk382PkB7_Nbp... (flutter/engine#39107)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
* Clarify messenger APIs * Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
MethodCalldocumentation made it seem like you must unregister handlers. This is not necessary during engine shutdown as that causes a crash after #36909. This attempts to improve the comments & crashes for clarity.See the conversation in #38941
New crash messages:
Addresses flutter/flutter#118611
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.