Get the vulkan backend working again #39103
Conversation
iskakaushik
commented
Jan 24, 2023
iskakaushik
commented
- Disables modern features as SSBOs are wired on Vulkan yet.
- Sub-optimal presentation mode must not be a fatal issue.
- Allow for shader outputs not to be consumed.
* Disables modern features as SSBOs are wired on Vulkan yet. * Sub-optimal presentation mode must not be a fatal issue. * Allow for shader outputs not to be consumed.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
impeller/tools/impeller.gni
Outdated
| @@ -18,7 +18,7 @@ declare_args() { | |||
| impeller_enable_opengles = is_mac || is_linux || is_win || is_android | |||
|
|
|||
| # Whether the Vulkan backend is enabled. | |||
| impeller_enable_vulkan = is_linux || is_android | |||
| impeller_enable_vulkan = is_mac || is_linux || is_android | |||
There was a problem hiding this comment.
Is the Vulkan playground harness configured to use the SwiftShader ICD by default on MacOS? If not, might be worth adding a doc about setting up Vulkan for MacOS here (getting LunarG SDK, environment vars for MoltenVK, etc). FYI @chinmaygarde
There was a problem hiding this comment.
added a issue flutter/flutter#119083
iskakaushik
changed the title
iskakaushik
added
e: impeller
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 39103, due to - The status or check suite Mac Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
iskakaushik
added
the
autosubmit
…119201) * c01d4a144 Roll Skia from c4b171fe5668 to 393fb1ec80f4 (9 revisions) (flutter/engine#39138) * 308ce918f Get the vulkan backend working again (flutter/engine#39103)
