[fuchsia] Diagnostics directory rights are R* #39203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
sebmarchand
approved these changes
Jan 27, 2023
|
Do you need me to squash and merge? |
|
Thank you for the review! Looks like I also need your help to submit it indeed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 28, 2023
…119376) * f03b12374 [fuchsia] Migrate to new RealmBuilder API (flutter/engine#39205) * 225ae8733 [fuchsia] Diagnostics directory rights are R* (flutter/engine#39203)
miguelfrde
added a commit
to miguelfrde/engine
that referenced
this pull request
Jan 30, 2023
This reverts commit 225ae87.
miguelfrde
added a commit
to miguelfrde/engine
that referenced
this pull request
Jan 31, 2023
This reverts commit 225ae87.
tarobins
pushed a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with https://fuchsia-review.git.corp.google.com/c/fuchsia/+/792471