Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac #39210

Merged
merged 2 commits into from Jan 28, 2023

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 27, 2023

Similar to

if uname -m | grep "arm64"; then
variant="host_debug_unopt_arm64"
else
variant="host_debug_unopt"
fi

#38426

Fixes flutter/flutter#119373

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 27, 2023
@jmagman jmagman changed the title Default to using an arm iOS simulator variant on Apple Silicon Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac Jan 27, 2023
@jmagman
Copy link
Member Author

jmagman commented Jan 27, 2023

@gaaclarke I tested this on an Intel Mac to make sure it didn't regress, would you mind trying it on your M1?

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, tested on m1

@jmagman
Copy link
Member Author

jmagman commented Jan 28, 2023

Linux Android Emulator Tests passed on rerun but it didn't update the status...
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Android%20Emulator%20Tests/4919/overview
This change definitely wouldn't have caused that panic, and I don't see any other instances of it in previous runs.
I'll push an empty commit.

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 28, 2023
@auto-submit auto-submit bot merged commit 3d0306d into flutter:main Jan 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 28, 2023
…119405)

* 3d0306d97 Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac (flutter/engine#39210)

* 0b6576ff3 Roll Dart SDK from 135f4c51c9ff to f9583e13e214 (2 revisions) (flutter/engine#39221)

* 3394b84cc Roll Fuchsia Mac SDK from 11wOrGFBXTHgxQVOi... to 1TFy9RSFMfNy7JpQU... (flutter/engine#39223)
@jmagman jmagman deleted the scenario-arm-sim branch January 31, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
2 participants