Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on timings for dimension_provider unit test. #39343

Merged
merged 1 commit into from Feb 2, 2023
Merged

Don't rely on timings for dimension_provider unit test. #39343

merged 1 commit into from Feb 2, 2023

Conversation

eyebrowsoffire
Copy link
Contributor

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 2, 2023
ditman
ditman approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for removing test flakiness!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 2, 2023
@auto-submit auto-submit bot merged commit 510ecfa into flutter:main Feb 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
510ecfa93 Don't rely on timings for dimension_provider unit test. (fl…
fffcdad 
…utter/engine#39343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
510ecfa93 Don't rely on timings for dimension_provider unit test. (fl…
b8b9fff 
…utter/engine#39343)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
510ecfa93 Don't rely on timings for dimension_provider unit test. (fl…
cf96546 
…utter/engine#39343)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (#…
72f9cf5 
…119859)

* 510ecfa93 Don't rely on timings for dimension_provider unit test. (flutter/engine#39343)

* b1ccae745 Roll Skia from 60242c4ea6a7 to c2d81db3ef41 (5 revisions) (flutter/engine#39344)

* 616ecd8be [Web][HTML] Add mirrored characters support for RTL languages (flutter/engine#39162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@eyebrowsoffire @ditman