Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single FlGLArea #39473

Merged
merged 1 commit into from Mar 7, 2023
Merged

Conversation

robert-ancell
Copy link
Contributor

Further simplification from #39467

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@robert-ancell robert-ancell marked this pull request as draft February 8, 2023 02:32
@robert-ancell
Copy link
Contributor Author

@jpnurmi please try this and see if it resolved your first frame issue.

@robert-ancell
Copy link
Contributor Author

Fast clicking and dragging on the (+) button is causing crashes with this branch, which don't seem reproducible with the previous branches.

@robert-ancell
Copy link
Contributor Author

The crashes seem to be related to getting leave events after releasing the button. I don't know why GTK is taking focus away :/

@jpnurmi
Copy link
Member

jpnurmi commented Feb 8, 2023

Thanks! I'm no longer able to reproduce the blank window issue with this.

@robert-ancell
Copy link
Contributor Author

Fixed crash, should be good to review once #39467 is landed.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@cbracken
Copy link
Member

cbracken commented Mar 1, 2023

Looks like this will need to be rebased to tip-of-tree to deal with a few conflicts.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2023
@auto-submit auto-submit bot merged commit 5bfd3cc into flutter:main Mar 7, 2023
35 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2023
@robert-ancell robert-ancell deleted the single-glarea branch March 9, 2023 03:10
noelex added a commit to noelex/engine that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-linux
Projects
None yet
3 participants