New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a single FlGLArea #39473
Use a single FlGLArea #39473
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@jpnurmi please try this and see if it resolved your first frame issue. |
Fast clicking and dragging on the (+) button is causing crashes with this branch, which don't seem reproducible with the previous branches. |
The crashes seem to be related to getting leave events after releasing the button. I don't know why GTK is taking focus away :/ |
Thanks! I'm no longer able to reproduce the blank window issue with this. |
033ad10
to
d8583ff
Compare
Fixed crash, should be good to review once #39467 is landed. |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
Looks like this will need to be rebased to tip-of-tree to deal with a few conflicts. |
d8583ff
to
8480820
Compare
d5db9e2
to
dcd6c1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 5bfd3cc.
Further simplification from #39467