Added wide gamut colors to offscreen buffers #39482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
offscreen-wide-gamut
branch
from
fd23012
to
a2e1384
Compare
gaaclarke
force-pushed
the
offscreen-wide-gamut
branch
from
a2e1384
to
e6da784
Compare
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
8 tasks
bdero
approved these changes
Feb 13, 2023
| @@ -86,6 +92,8 @@ constexpr MTLPixelFormat ToMTLPixelFormat(PixelFormat format) { | |||
| return SafeMTLPixelFormatBGR10_XR_sRGB(); | |||
| case PixelFormat::kB10G10R10XR: | |||
| return SafeMTLPixelFormatBGR10_XR(); | |||
| case PixelFormat::kB10G10R10A10XR: | |||
| return SafeMTLPixelFormatBGRA10_XR(); | |||
There was a problem hiding this comment.
Also add reverse conversion to ToMTLBlendFactor below.
There was a problem hiding this comment.
The reverse for this is in FromMTLPixelFormat. I think that's what you were thinking, right?
| @@ -138,6 +138,7 @@ constexpr vk::Format ToVKImageFormat(PixelFormat format) { | |||
| switch (format) { | |||
| case PixelFormat::kUnknown: | |||
| case PixelFormat::kB10G10R10XR: | |||
| case PixelFormat::kB10G10R10A10XR: | |||
There was a problem hiding this comment.
Also add reverse conversion to ToPixelFormat below.
There was a problem hiding this comment.
There's no reverse for this yet since it's mapped to vk::Format::eUndefined. I don't think this format will ever be used with vulkan as far as I know.
bdero
reviewed
Feb 13, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 15, 2023
…120821) * b59787f40 Roll Skia from cd19d680b078 to 21627ff455d0 (2 revisions) (flutter/engine#39650) * 9af56b3ee [macOS] Set textfield autofill type (flutter/engine#39632) * a8b3d1af5 Added wide gamut colors to offscreen buffers (flutter/engine#39482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#117182
integration test: flutter/flutter#120131
I spent some time trying to make BGR10_XR work but I couldn't figure it out, so I punted on it for now. Getting smaller textures is more important for now.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.