Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ios_engine debug, profile and release. #39724

Merged
merged 2 commits into from Feb 17, 2023
Merged

Integrate ios_engine debug, profile and release. #39724

merged 2 commits into from Feb 17, 2023

Conversation

godofredoc
Copy link
Contributor

This provides greater reusability of subbuilds saving an approximate of 6 bots per run.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Integrate ios_engine debug, profile and release.
d84d476 
This provides greater reusability of subbuilds saving an approximate of
6 bots per run.
godofredoc
godofredoc commented Feb 17, 2023
View reviewed changes
Copy link
Contributor Author

@godofredoc godofredoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total execution time didn't change too much. ~15min

jmagman
jmagman reviewed Feb 17, 2023
View reviewed changes
ci/builders/mac_ios_engine.json Outdated
@@ -89,12 +133,72 @@
"script": "flutter/sky/tools/create_full_ios_framework.py",
"language": "python3"
},
{
"name": "Profile-FlutterMacOS.framework",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I asked this in another PR, but why is building the iOS artifacts called FlutterMacOS.framework? FlutterMacOS.framework is the macOS embedder artifact...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was probably an attempt to use a better name than artifacts, which name should we use here? this is just what is shown in the step name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile-Flutter.xcframework or Profile-ios-Flutter.xcframework would be more accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

jmagman
jmagman reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM
@zanderso do you have any objections to combining the runtime modes into one builder?

ci/builders/mac_ios_engine.json Outdated
@@ -89,12 +133,72 @@
"script": "flutter/sky/tools/create_full_ios_framework.py",
"language": "python3"
},
{
"name": "Profile-FlutterMacOS.framework",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile-Flutter.xcframework or Profile-ios-Flutter.xcframework would be more accurate.

@zanderso
Copy link
Member

This LGTM @zanderso do you have any objections to combining the runtime modes into one builder?

My understanding is that the builds for each runtime mode will run in parallel in a separate drone. If that is true, then this lgtm.

@godofredoc
Copy link
Contributor Author

This LGTM @zanderso do you have any objections to combining the runtime modes into one builder?

My understanding is that the builds for each runtime mode will run in parallel in a separate drone. If that is true, then this lgtm.

That is correct, everything runs as sub-builds.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 17, 2023
@auto-submit auto-submit bot merged commit 1d7f0c6 into flutter:main Feb 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
1d7f0c66c Integrate ios_engine debug, profile and release. (flutter/e…
e8e294e 
…ngine#39724)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 18, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 2b2780185dd5 to a37e27b77008 (2 revisions) (#…
0fa6527 
…121020)

* 1d7f0c66c Integrate ios_engine debug, profile and release. (flutter/engine#39724)

* a37e27b77 [web] Don't include end-of-line characters in line boundary (flutter/engine#39693)
@godofredoc godofredoc deleted the single_ios branch March 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman left review comments

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
3 participants
@godofredoc @zanderso @jmagman