Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuchsia] Remove CFv1 support #39732

Merged
merged 1 commit into from Mar 2, 2023
Merged

[fuchsia] Remove CFv1 support #39732

merged 1 commit into from Mar 2, 2023

Conversation

anp
Copy link
Contributor

@anp anp commented Feb 18, 2023 •
edited

Removes support from the Fuchsia embedding for Component Framework v1 (CMX files) which is being turned down.

To my knowledge, all existing builds using CMX-based Flutter components are using prebuilts with a Flutter engine from early December 2022 and will not be affected by this change.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@anp
Copy link
Contributor Author

anp commented Feb 24, 2023

Note for myself: going to also look at deleting component_v1.h and cc.

@anp anp force-pushed the rm-runner-cmx branch 4 times, most recently from 7401668 to e4624d3 Compare March 1, 2023 16:43
@anp anp changed the title [fuchsia] WIP remove component framework v1 support [fuchsia] Remove CFv1 support Mar 1, 2023
@anp
[fuchsia] Remove component framework v1 support.
614aeef 
There are no longer any CMX-based components outside of prebuilts
which are run by existing flutter runner prebuilts.
@arbreng arbreng self-requested a review March 1, 2023 21:58
@anp anp marked this pull request as ready for review March 1, 2023 22:04
@arbreng arbreng added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 1, 2023
@arbreng arbreng merged commit 24e69c8 into flutter:main Mar 2, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
24e69c8fb [fuchsia] Remove component framework v1 support. (flutter/e…
1756e1d 
…ngine#39732)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
24e69c8fb [fuchsia] Remove component framework v1 support. (flutter/e…
c342b91 
…ngine#39732)
@anp anp deleted the rm-runner-cmx branch March 2, 2023 07:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
24e69c8fb [fuchsia] Remove component framework v1 support. (flutter/e…
22c8ba3 
…ngine#39732)
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
@anp @chinmaygarde
[fuchsia] Remove component framework v1 support. (flutter#39732)
62e296d 
There are no longer any CMX-based components outside of prebuilts
which are run by existing flutter runner prebuilts.
@anp anp mentioned this pull request Mar 7, 2023
Merged
anp added a commit to anp/engine that referenced this pull request Mar 7, 2023
@anp
Revert "[fuchsia] Remove component framework v1 support. (flutter#39732…
d31a166 
…)"

This reverts commit 24e69c8.
tarobins pushed a commit that referenced this pull request Mar 7, 2023
@anp
Revert "[fuchsia] Remove component framework v1 support. (#39732)" (#…
3019109 
…40104)

This reverts commit 24e69c8.
anp added a commit to anp/engine that referenced this pull request Mar 9, 2023
@anp
Reland "[fuchsia] Remove component framework v1 support. (flutter#39732…
7431cb7 
…)"

Previously reverted in flutter#40104, this should now be safe to reland as
the last dependency has been deleted internally.

This reverts commit 3019109.
arbreng pushed a commit that referenced this pull request Mar 9, 2023
@anp
Reland "[fuchsia] Remove component framework v1 support. (#39732)" (#…
b9fba2f 
…40198)

Previously reverted in #40104, this should now be safe to reland as
the last dependency has been deleted internally.

This reverts commit 3019109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbreng arbreng arbreng approved these changes

Assignees
No one assigned
Labels
platform-fuchsia waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
2 participants
@anp @arbreng