-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Embedder API] Add CODEOWNERS #39784
Conversation
# This file defines an Application Binary Interface (ABI) that must maintain | ||
# both forward and backward compatibility. Changes should be heavily | ||
# scrutinized as mistakes are irreversible. | ||
/shell/platform/embedder/embedder.h @cbracken @chinmaygarde |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if I should add anyone else.
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
fc64804
to
7e13025
Compare
009b2ff
to
599d7d8
Compare
…121286) * 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727) * f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527) * 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782) * 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776) * 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783) * 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787) * ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790) * d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791) * 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792) * eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786) * 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777) * 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793) * e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789) * 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794) * cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795) * ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691) * c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797) * ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784) * 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798) * 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
Add a CODEOWNERS and add suggested reviewers for the embedder API.
Part of: flutter/flutter#121176.
See go/flutter-semantics-abi.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.