[Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). #39932

gaaclarke · 2023-02-28T00:46:51Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2023-03-01T01:54:02Z

lib/ui/painting/image_encoding_impeller.cc

+
+}  // namespace
+
+void ImageEncodingImpeller::ConvertDlImageToSkImage(


I made this public for easier testing. With a little bit of work I could make the tests work on the existing public api. There is just a bit of threading work required to do that.

dnfield · 2023-03-01T21:46:38Z

ci/licenses_golden/licenses_flutter

@@ -1481,6 +1481,7 @@ ORIGIN: ../../../flutter/impeller/renderer/gpu_tracer.cc + ../../../flutter/LICE
 ORIGIN: ../../../flutter/impeller/renderer/gpu_tracer.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/host_buffer.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/renderer/host_buffer.h + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/impeller/renderer/mocks.h + ../../../flutter/LICENSE


nit: maybe this belongs in the excluded one instead? I think we're doing that with at least some test-only files.

Do you have a pointer to an example? I can ask Hixie.

moved it over, I think this makes sense

auto-submit · 2023-03-01T23:14:29Z

auto label is removed for flutter/engine, pr: 39932, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label.

…s downscaling to sRGB). (flutter/engine#39932)

…ing to sRGB). (flutter#39932) [Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB).

armandojimenez · 2023-05-11T03:53:27Z

I am getting this error: Failed to get color type from pixel format when using the palette_generator package with wide color gamut enabled in Flutter 3.10, is this the issue?

gaaclarke · 2023-05-11T16:49:48Z

I am getting this error: Failed to get color type from pixel format when using the palette_generator package with wide color gamut enabled in Flutter 3.10, is this the issue?

Could be. There was no intentional breaking change. Can you file an issue please with reproduction code? Bonus points if the reproduction code uses the ui package directly instead of relying on a plugin.

armandojimenez · 2023-05-11T19:01:33Z

Also just tried using ColorSheme.fromImageProvider(), announced in the What's new in Flutter, does not work with wide color gamut enabled, so a simple code like this:

final colorSheme = await ColorScheme.fromImageProvider(
              provider: Image.file(File(savedPath)).image);
)

Should give the error, I don't have the time right now to create the issue, but should be easy to reproduce just using ColorSheme.fromImageProvider()

armandojimenez · 2023-05-11T19:38:23Z

NVM, looks like the problem is with the Screenshot package with Wide gamut enabled

chinmaygarde changed the title ~~Made toByteData work on wide gamut images (always downscaling to sRGB).~~ [Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). Feb 28, 2023

chinmaygarde assigned gaaclarke Feb 28, 2023

chinmaygarde added the e: impeller label Feb 28, 2023

gaaclarke added 3 commits February 28, 2023 16:37

Made toByteData work on wide gamut images (always downscaling to sRGB).

b599167

added unit test

22cd9a3

cleaned up the tests

88ed94b

gaaclarke force-pushed the wide-gamut-tobytedata branch from e860873 to 88ed94b Compare March 1, 2023 00:37

gaaclarke added 3 commits February 28, 2023 17:17

fixed up after rebase

5ba4db6

added test for bgr10_xr

f15abb5

added license update

daec67a

gaaclarke marked this pull request as ready for review March 1, 2023 01:51

gaaclarke commented Mar 1, 2023

View reviewed changes

gaaclarke requested a review from dnfield March 1, 2023 01:54

added docstrings

5d073e1

dnfield reviewed Mar 1, 2023

View reviewed changes

dnfield approved these changes Mar 1, 2023

View reviewed changes

moved the license listing to excluded

37d0121

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023

gaaclarke added 2 commits March 1, 2023 15:50

moved impeller/renderer/mocks.h to impeller/renderer/testing/mocks.h

5f4a0cb

removed mocks.h from excluded and listed its directory instead

b69c32a

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 2, 2023

auto-submit bot merged commit 0562901 into flutter:main Mar 2, 2023

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 056290127820 (6 revisions) flutter/flutter#121765

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

f4d5183

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 0661e2717559 (7 revisions) flutter/flutter#121766

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

5614c84

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 23d2931f4896 (8 revisions) flutter/flutter#121767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

fea3daa

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to f73ac7d27f1b (9 revisions) flutter/flutter#121771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

e59ae65

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 24e69c8fb1fd (10 revisions) flutter/flutter#121772

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

8246ec1

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 24e69c8fb1fd (10 revisions) flutter/flutter#121776

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

31573de

…s downscaling to sRGB). (flutter/engine#39932)

engine-flutter-autoroll mentioned this pull request Mar 2, 2023

Roll Flutter Engine from f85e4c667575 to 385d02891638 (11 revisions) flutter/flutter#121779

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023

056290127 [Impeller] Made toByteData work on wide gamut images (alway…

681c82e

…s downscaling to sRGB). (flutter/engine#39932)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). #39932

[Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). #39932

gaaclarke commented Feb 28, 2023 •

edited

gaaclarke Mar 1, 2023

dnfield Mar 1, 2023

gaaclarke Mar 1, 2023

gaaclarke Mar 1, 2023

auto-submit bot commented Mar 1, 2023

armandojimenez commented May 11, 2023

gaaclarke commented May 11, 2023

armandojimenez commented May 11, 2023

armandojimenez commented May 11, 2023 •

edited


		} // namespace

		void ImageEncodingImpeller::ConvertDlImageToSkImage(

[Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). #39932

[Impeller] Made toByteData work on wide gamut images (always downscaling to sRGB). #39932

Conversation

gaaclarke commented Feb 28, 2023 • edited

Pre-launch Checklist

gaaclarke Mar 1, 2023

Choose a reason for hiding this comment

dnfield Mar 1, 2023

Choose a reason for hiding this comment

gaaclarke Mar 1, 2023

Choose a reason for hiding this comment

gaaclarke Mar 1, 2023

Choose a reason for hiding this comment

auto-submit bot commented Mar 1, 2023

armandojimenez commented May 11, 2023

gaaclarke commented May 11, 2023

armandojimenez commented May 11, 2023

armandojimenez commented May 11, 2023 • edited

gaaclarke commented Feb 28, 2023 •

edited

armandojimenez commented May 11, 2023 •

edited