Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Impeller] Uniquely label offscreen resources" #39993

Merged
merged 1 commit into from Mar 1, 2023

Conversation

godofredoc
Copy link
Contributor

Reverts #39987

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@godofredoc godofredoc added the revert Label used to revert changes in a closed and merged pull request. label Mar 1, 2023
@auto-submit auto-submit bot merged commit f249919 into main Mar 1, 2023
@auto-submit auto-submit bot deleted the revert-39987-bdero/label-offscreen branch March 1, 2023 23:01
bdero added a commit to bdero/flutter-engine that referenced this pull request Mar 1, 2023
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests revert Label used to revert changes in a closed and merged pull request.
Projects
None yet
2 participants