New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not end the frame in the raster cache if ScopedFrame::Raster returns kResubmit #40007
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the fix @jason-simmons
44bb774
to
fb6c21a
Compare
…ns kResubmit A kResubmit status indicates that ScopedFrame::Raster did not actually paint the frame. Fixes flutter/flutter#121678
fb6c21a
to
e2f4cb6
Compare
…ster returns kResubmit (flutter/engine#40007)
…ster returns kResubmit (flutter/engine#40007)
…ster returns kResubmit (flutter/engine#40007)
…ster returns kResubmit (flutter/engine#40007)
…ns kResubmit (flutter#40007) Do not end the frame in the raster cache if ScopedFrame::Raster returns kResubmit
…ster returns kResubmit (flutter/engine#40007)
…ster returns kResubmit (flutter/engine#40007)
kResubmit (along with kSkipAndRetry) indicate that ScopedFrame::Raster did not actually paint the frame.
Fixes flutter/flutter#121678