Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Add README.md for macOS embedder #40032

Merged
merged 1 commit into from Mar 3, 2023
Merged

[macOS] Add README.md for macOS embedder #40032

merged 1 commit into from Mar 3, 2023

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Mar 2, 2023

Describes how to build and test the macOS embedder.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken force-pushed the macos-readme branch 2 times, most recently from b858ef8 to fa3d265 Compare March 2, 2023 21:54
loic-sharma
loic-sharma reviewed Mar 2, 2023
View reviewed changes
shell/platform/darwin/macos/README.md Outdated Show resolved Hide resolved
shell/platform/darwin/macos/README.md Outdated Show resolved Hide resolved
@cbracken cbracken force-pushed the macos-readme branch 3 times, most recently from 43fc715 to b1cbd42 Compare March 2, 2023 23:17
@cbracken
[macOS] Add README.md for macOS embedder
27ab871 
Describes how to build and test the macOS embedder.
@cbracken cbracken merged commit 106db83 into flutter:main Mar 3, 2023
@cbracken cbracken deleted the macos-readme branch March 3, 2023 01:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
13c3ade 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
1694fa6 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
eccee73 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
004c11c 
)
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
@cbracken @chinmaygarde
[macOS] Add README.md for macOS embedder (flutter#40032)
03039e4 
Describes how to build and test the macOS embedder.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
2ae674e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
106db839d [macOS] Add README.md for macOS embedder (flutter/engine#40032
3afb217 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog left review comments

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees
No one assigned
Labels
platform-macos
Projects
None yet
Milestone
No milestone
3 participants
@cbracken @loic-sharma @gspencergoog