Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate desktop builds to its own builder. #40074

Merged
merged 1 commit into from Mar 4, 2023
Merged

Separate desktop builds to its own builder. #40074

merged 1 commit into from Mar 4, 2023

Conversation

godofredoc
Copy link
Contributor

Desktop artifacts are generated using the same linux host configurations causing conflicts when generating archives with different gn flags. This PR separates linux desktop builds to its own builder.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Separate desktop builds to its own builder.
3c6d6be 
Desktop artifacts are generated using the same linux host configurations
causing conflicts when generating archives with different gn flags. This
PR separates linux desktop builds to its own builder.
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2023
@auto-submit auto-submit bot merged commit de724e2 into flutter:main Mar 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2023
@engine-flutter-autoroll
de724e263 Separate desktop builds to its own builder. (flutter/engine…
dab6986 
…#40074)
@godofredoc godofredoc deleted the move_desktop branch March 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@godofredoc @loic-sharma