Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lower Dart SDK constraints to 3.0 #40178

Merged
merged 4 commits into from Mar 15, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 9, 2023

Part of flutter/flutter#118837.

This will allow us to use the latest Dart 3.0 features. A PR that migrates some classes to use class modifiers where appropriate will follow.

Blocked on waiting for Dart v3.0.0-325.0.dev to roll into the engine (happening in #40296)

Excluding the web engine from this because of flutter/flutter#122724.

@flutter-dashboard flutter-dashboard bot added platform-fuchsia platform-web Code specifically for the web engine labels Mar 9, 2023
@goderbauer goderbauer force-pushed the syncSdkVersion branch 4 times, most recently from ec461e7 to 9b55f45 Compare March 13, 2023 18:29
@goderbauer goderbauer changed the title WIP Bump lower Dart SDK constraints to 3.0 Mar 13, 2023
@goderbauer
Copy link
Member Author

cc @jakemac53 @chingjun FYI, landing this is still blocked on waiting for Dart v3.0.0-325.0.dev to roll into the engine (expected sometimes today). I will prepare a similar PR for the flutter/flutter repository.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Mar 15, 2023

test-exempt: configuration change

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2023
@auto-submit auto-submit bot merged commit e143b30 into flutter:main Mar 15, 2023
43 checks passed
zanderso added a commit that referenced this pull request Mar 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
auto-submit bot pushed a commit that referenced this pull request Mar 15, 2023
Revert "Bump lower Dart SDK constraints to 3.0"
@goderbauer goderbauer deleted the syncSdkVersion branch March 15, 2023 19:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 15, 2023
…122746)

* 3c3cbc738 Manual roll Dart SDK from c766fffb626e to 3b109a04f783 (9 revisions) (flutter/engine#40296)

* dee0ae590 [Impeller] Make matrix image filters work as expected with nested saving layers (flutter/engine#40299)

* 835759f4c Roll Skia from 4d90ba479527 to 3b9131c65c01 (5 revisions) (flutter/engine#40304)

* bbde3a77b Roll Fuchsia Linux SDK from BRE9jdqYpdkbU0j7H... to YaWqKKuj-fAqfpKCm... (flutter/engine#40306)

* 1a7e7c468 Roll Dart SDK from 3b109a04f783 to 5c210933cdfe (2 revisions) (flutter/engine#40307)

* 66a3324cf Analyze more shaders (flutter/engine#40285)

* 405c8513e [Impeller] Improve performance of CupertinoPicker with opacity peephole (flutter/engine#40101)

* 9fc3246bf Reland "Make FlutterTest the default test font" (#40188) (flutter/engine#40245)

* 3ed9f1236 Reland: "Added wide-gamut color support for `ui.Image.toByteData` and `ui.Image.colorSpace`" (flutter/engine#40312)

* e143b309c Bump lower Dart SDK constraints to 3.0 (flutter/engine#40178)

* 086b1a022 [impeller] implement GetPositionUVBuffer (flutter/engine#40248)

* ec151bf2c Revert Dart SDK to c766fffb626e (flutter/engine#40315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests platform-fuchsia platform-web Code specifically for the web engine
Projects
None yet
3 participants