Do not include wasm-opt with in-tree dart sdk build #40195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include wasm-opt.
mdebbar
approved these changes
Mar 10, 2023
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 10, 2023
Hide this behind a flag, so that we can disable it when building in the flutter in-tree build. The flag will be set to false for the in-tree flutter build, see flutter/engine#40195 Change-Id: I248376985d05bfb248a2eab6fa377cbb01d75654 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288040 Commit-Queue: Jackson Gardner <jacksongardner@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is being added here in an upcoming dart sdk change:
https://dart-review.googlesource.com/c/sdk/+/288040