Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 32 cores in Linux Host and Web Engine. #40200

Merged
merged 1 commit into from Mar 10, 2023
Merged

Use 32 cores in Linux Host and Web Engine. #40200

merged 1 commit into from Mar 10, 2023

Conversation

godofredoc
Copy link
Contributor

This speeds up builds that have regressed adding 15+ minutes to the execution time.

Bug: flutter/flutter#122211

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use 32 cores in Linux Host and Web Engine.
baa9dd0 
This speeds up builds that have regressed adding 15+ minutes to the
execution time.

Bug: flutter/flutter#122211
eyebrowsoffire
eyebrowsoffire approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@godofredoc godofredoc added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Mar 9, 2023
@auto-submit auto-submit bot merged commit e323b11 into flutter:main Mar 10, 2023
43 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
e323b11a5 Use 32 cores in Linux Host and Web Engine. (flutter/engine#…
387a2d3 
…40200)
@godofredoc godofredoc deleted the use_32 branch April 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
3 participants
@godofredoc @zanderso @eyebrowsoffire