[macOS] Rename FlutterViewController.id to viewId #40323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`id` is a type in Objective-C similar to dynamic in Dart, and while it *can* be used as an identifier, it's bad practice to do so and results in unidiomatic code. `viewId` is also more clearly indicates the purpose of this identifier. Also replaces the use of @dynamic (which is meant to indicate properties whose implementation is either added at runtime or stashed away in a superclass) with @synthesize, which is an idiomatic way to declare that an ivar `_foo` should be synthesized for property `foo`. While this is renaming a public property and thus constitutes a breaking change, multi-view support is still under development and thus, practically speaking, this should not be a breaking change.
|
Note - I will send a followup that deals with the other It looks like the |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2023
|
Do we need the Edit: Does ObjC auto-synthesize readonly properties? |
You got it -- nope, it doesn't. We've provided an implementation of the accessor for viewId, so it's not synthesized by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idis a type in Objective-C similar to dynamic in Dart, and while it can be used as an identifier, it's bad practice to do so and results in unidiomatic code.viewIdalso more clearly indicates the purpose of this identifier.Also replaces the use of
@dynamic(which is meant to indicate properties whose implementation is either added at runtime or stashed away in a superclass) with@synthesize, which is an idiomatic way to declare that an ivar_fooshould be synthesized for propertyfoo.While this is renaming a public property and thus constitutes a breaking change, multi-view support is still under development and thus, practically speaking, this should not be a breaking change.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.