replace some ._() constructors with class modifiers #40328
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
|
Why |
Because they also may not be constructed: https://github.com/dart-lang/language/blob/master/accepted/future-releases/class-modifiers/feature-specification.md#syntax |
Yes! (see also PR description) it is waiting for #40318 :) |
goderbauer
force-pushed
the
classModifiers
branch
2 times, most recently
from
c3699a4
to
9dd9f48
Compare
|
In addition to that it turned out that the api_check tool was also hard-coding an outdated dart version to do its internal analysis. I bumped that up. PTAL at the last commit, @cbracken. Thanks! |
goderbauer
force-pushed
the
classModifiers
branch
from
6649f4e
to
90e3bd0
Compare
|
I had to update the analyzer used by the |
| @@ -18,7 +18,6 @@ dependencies: | |||
| path: ../../third_party/web_test_fonts | |||
|
|
|||
| dev_dependencies: | |||
| analyzer: 5.2.0 | |||
There was a problem hiding this comment.
Not sure why this is being removed.
There was a problem hiding this comment.
This dependency is unused.
There was a problem hiding this comment.
What about the IDE? Which analyzer does it use when I open the lib/web_ui folder? For some reason, I always assumed the IDE used the analyzer dependency version, but I'm not 100% sure.
There was a problem hiding this comment.
It uses the analyzer of the dart SDK configured in the IDE. This dependency is used for ‘package:analyzer/…’ imports of which there don’t seem to be any within web_ui.
goderbauer
added
the
autosubmit
…r/engine#40328) (#122908) Roll Flutter Engine from 59e21ffbf9b8 to 7f42c3fc22b3 (1 revision)
flutter/engine#40328) (#122908) Commit: 725d9ca214f683817bc017bbc1001b3aa7217f22
These constructors were only there to prevent instantiation and extension. We now have class modifiers for that!
Part of flutter/flutter#118837.
To be submitted after #40318. (presubmits will fail until it is merged)