Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[web] Better way to detect CanvasKit variant" #40329

Merged
merged 1 commit into from Mar 15, 2023

Conversation

gaaclarke
Copy link
Member

Reverts #40154

Link to failure:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Web%20Engine/15924/overview

failure text:

05:04 �[32m+312�[0m�[33m ~14�[0m�[31m -4�[0m: test/canvaskit/image_golden_test.dart: CanvasKit Images (webcodecs) the same image can be rendered on difference surfaces�[0m                                                           
05:04 �[32m+312�[0m�[33m ~14�[0m�[31m -4�[0m: �[1m�[90mloading test/ui/path_test.dart�[0m�[0m                                                                                                                                                      
goldctl imgtest add stdout: Given image with hash efdfae048b059fa1fdd0cd04a046b5a5 for test canvaskit_read_back_decoded_image_webcodecs
Expectation for test: 232f176cb03fce28273397dea4d5d125 (positive)
Expectation for test: efdfae048b059fa1fdd0cd04a046b5a5 (negative)
Untriaged or negative image: https://flutter-engine-gold.skia.org/detail?test=canvaskit_read_back_decoded_image_webcodecs&digest=efdfae048b059fa1fdd0cd04a046b5a5


goldctl imgtest add stderr: Test: canvaskit_read_back_decoded_image_webcodecs FAIL

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 15, 2023
@gaaclarke
Copy link
Member Author

Landing on red to open the tree.

@gaaclarke gaaclarke merged commit 3f92f8e into main Mar 15, 2023
31 of 34 checks passed
@gaaclarke gaaclarke deleted the revert-40154-ck_requires_client_icu branch March 15, 2023 22:25
mdebbar added a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
2 participants